Review main Merged

78275[TASK] Rename two test fixture files

Christian Kuhn CR +2 V +2 Normal +27 −46 updated 03/27/23, 18:35

Commit message

phpunit 10 expects files that end with Test.php
to contain tests. Two fixture files are renamed
since phpunit detects them as test cases, but
they are not.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 79

  1. Christian Kuhn uploaded patch set 1 03/27/23, 17:58

  2. Christian Kuhn uploaded patch set 2 03/27/23, 18:04

  3. Christian Kuhn updated the commit message in patch set 3 03/27/23, 18:05

  4. core-ci voted on patch set 1 V +1 03/27/23, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39713

  5. core-ci voted on patch set 3 V +1 03/27/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39715

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 03/27/23, 18:14

  7. Wouter Wolters voted on patch set 3 V +1 CR +1 03/27/23, 18:32

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 03/27/23, 18:35

  9. Christian Kuhn merged patch set 4 03/27/23, 18:35