Review main Merged

78277[TASK] Avoid setMethodsExcept() for phpunit 10

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 03/27/23, 19:43

Commit message

setMethodsExcept() on mocks has been removed
with phpunit 10.

There are three usages in one test case, those
can be converted to onlyMethods() easily.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/27/23, 19:12

  2. core-ci voted on patch set 1 V +1 03/27/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39719

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 03/27/23, 19:36

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 03/27/23, 19:42

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/27/23, 19:43

  6. Christian Kuhn merged patch set 2 03/27/23, 19:43