Review main Merged

78281[TASK] Static data providers in Tests/Functional

Christian Kuhn CR +2 V +2 Hard +275 −275 updated 03/27/23, 21:44

Commit message

phpunit ^10 expects test data providers to be static.

Using rector rule StaticDataProviderClassMethodRector,
this bulk change adapts most of them in
typo3/sysext/*/Tests/Functional.

A couple of data providers use $this, those are left
out for now and need to be adapted with dedicated
patches since they need more refactoring.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 165

Show 145 more files

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/27/23, 21:20

  2. Oliver Klee voted on patch set 1 CR +1 03/27/23, 21:32

  3. core-ci voted on patch set 1 V +1 03/27/23, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39731

  4. Oliver Klee voted on patch set 1 V +1 03/27/23, 21:37

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 03/27/23, 21:44

  6. Stefan Bürk merged patch set 2 03/27/23, 21:44