78294[BUGFIX] Fix PHP warning in FormFieldViewHelper
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Marcus Schwemer +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Marcus Schwemer +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1316
-
Benni Mack uploaded patch set 1 03/28/23, 07:37
-
Oliver Klee commented on patch set 1 03/28/23, 08:10
-
Andreas Nedbal commented on patch set 1 03/28/23, 08:26
AbstractFormFieldViewHelper.php:365`TYPO3\CMS\Extbase\Error\Result::forProperty()` also expects a string parameter, so we need another cast here -
core-ci voted on patch set 1 V -1 03/28/23, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39750
-
Marcus Schwemer uploaded patch set 2
V -104/13/23, 06:43 -
Marcus Schwemer commented on patch set 2 04/13/23, 06:46
AbstractFormFieldViewHelper.php:298ReplyDoneAbstractFormFieldViewHelper.php:365ReplyDone -
core-ci voted on patch set 2 V +1 04/13/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40545
-
Oli Bartsch commented on patch set 2 V -1 04/13/23, 07:53
Getting TypeError TYPO3\CMS\Extbase\Reflection\ObjectAccess::getPropertyPath(): Argument #2 ($propertyPath) must be of type string, int given, called in /var/www/html/typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php on line 313 Will update -
Oli Bartsch uploaded patch set 3
V +104/13/23, 07:56 -
Oli Bartsch commented on patch set 3 V +1 CR +1 04/13/23, 07:56
Reply
Done -
Marcus Schwemer voted on patch set 3 V +1 CR +1 04/13/23, 08:00
-
Benni Mack voted on patch set 3 V +1 CR +1 04/13/23, 08:00
-
Oliver Klee voted on patch set 3 CR +1 04/13/23, 08:04
-
core-ci voted on patch set 3 V +1 04/13/23, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40548
-
Oli Bartsch voted on patch set 3 V +2 CR +2 04/13/23, 08:06
-
Oli Bartsch merged patch set 4 04/13/23, 08:06
AbstractFormFieldViewHelper.php:298