Review main Merged

78300[TASK] Deprecate TSFE->type

Benni Mack CR +2 V +2 Normal +104 −13 updated 04/12/23, 13:53

Commit message

This information can now be retrieved
from the page arguments object, as
it is encouraged to not rely on the global
TSFE pattern anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1017

  1. Benni Mack uploaded patch set 1 03/28/23, 10:54

  2. core-ci voted on patch set 1 V -1 03/28/23, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39759

  3. Georg Ringer uploaded patch set 2 V -1 03/28/23, 18:13

  4. core-ci voted on patch set 2 V +1 03/28/23, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39786

  5. Benni Mack updated the commit message in patch set 3 V +1 04/03/23, 10:57

  6. core-ci voted on patch set 3 V +1 04/03/23, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40011

  7. Benni Mack uploaded patch set 4 V +1 04/04/23, 15:18

  8. core-ci voted on patch set 4 V +1 04/04/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40098

  9. Benni Mack commented on patch set 5 V +1 04/04/23, 15:27

    Published edit on patch set 4.
  10. core-ci voted on patch set 5 V +1 04/04/23, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40099

  11. Benni Mack uploaded patch set 6 V +1 04/12/23, 08:19

  12. core-ci voted on patch set 6 V +1 04/12/23, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40489

  13. Oli Bartsch uploaded patch set 7 V +1 04/12/23, 13:09

  14. Oli Bartsch voted on patch set 7 V +1 CR +1 04/12/23, 13:09

  15. core-ci voted on patch set 7 V +1 04/12/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40507

  16. Christian Kuhn voted on patch set 7 V +2 CR +2 04/12/23, 13:53

  17. Christian Kuhn merged patch set 8 04/12/23, 13:53