Review main Merged

78301[BUGFIX] Prevent undefined array key in ext lowlevel

TYPO3com CR +2 V +2 Easy +4 −4 updated 03/28/23, 12:45

Commit message

There are several checks related to array key
'_CURRENT_VERSION' on versioned records. Since
PHP 8 those checks are not safe anymore and
can result in errors.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1116

  1. TYPO3com uploaded patch set 1 03/28/23, 10:55

  2. anonymized-52878 updated the commit message in patch set 2 03/28/23, 11:05

  3. core-ci voted on patch set 1 V +1 03/28/23, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39760

  4. core-ci voted on patch set 2 V +1 03/28/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39763

  5. Andreas Kienast updated the commit message in patch set 3 V +1 03/28/23, 11:38

  6. core-ci voted on patch set 3 V +1 03/28/23, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39767

  7. Oliver Klee voted on patch set 3 CR +1 03/28/23, 11:47

  8. Christian Kuhn commented on patch set 3 CR -1 03/28/23, 12:17

    will push

    CleanFlexFormsCommand.php:158

    this is not needed. keep ??

    CleanFlexFormsCommand.php:195

    this is not needed. keep ??

    DeletedRecordsCommand.php:233

    i'd prefer !($verRec['_CURRENT_VERSION'] ?? false) over isset here

    DeletedRecordsCommand.php:269

    i'd prefer !($verRec['_CURRENT_VERSION'] ?? false) over isset here
  9. Christian Kuhn uploaded patch set 4 CR +1 V +1 03/28/23, 12:21

  10. Christian Kuhn commented on patch set 3 CR -1 03/28/23, 12:21

    CleanFlexFormsCommand.php:158 Reply

    Done

    CleanFlexFormsCommand.php:195 Reply

    Done

    DeletedRecordsCommand.php:233 Reply

    Done

    DeletedRecordsCommand.php:269 Reply

    Done
  11. Oliver Klee voted on patch set 4 CR +1 03/28/23, 12:25

  12. core-ci voted on patch set 4 V +1 03/28/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39770

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 03/28/23, 12:36

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 03/28/23, 12:39

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 03/28/23, 12:45

  16. Christian Kuhn merged patch set 5 03/28/23, 12:45