Review main Merged

78303[TASK] Deprecate TypoScript config.xhtmlDoctype

Benni Mack CR +2 V +2 Easy +45 −1 updated 04/05/23, 15:10

Commit message

The "new" property config.doctype has been introduced in TYPO3 v6
and should be used now.

It's time to unify all of our settings.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1116

  1. Benni Mack uploaded patch set 1 03/28/23, 10:56

  2. core-ci voted on patch set 1 V -1 03/28/23, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39762

  3. Benni Mack updated the commit message in patch set 2 V -1 04/05/23, 09:52

  4. core-ci voted on patch set 2 V -1 04/05/23, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40170

  5. Benni Mack uploaded patch set 3 V -1 04/05/23, 10:21

  6. core-ci voted on patch set 3 V +1 04/05/23, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40174

  7. Benni Mack commented on patch set 4 V +1 04/05/23, 14:19

    Published edit on patch set 3.
  8. Andreas Kienast voted on patch set 4 CR +1 04/05/23, 14:25

  9. core-ci voted on patch set 4 V +1 04/05/23, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40191

  10. Andreas Kienast commented on patch set 4 CR -1 04/05/23, 14:27

    The log entry is really weird, will adapt the patch
  11. Andreas Kienast uploaded patch set 5 CR -1 V +1 04/05/23, 14:28

  12. Andreas Kienast voted on patch set 5 V +1 CR +1 04/05/23, 14:28

  13. core-ci voted on patch set 5 V +1 04/05/23, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40192

  14. Christian Kuhn voted on patch set 5 V +1 CR +1 04/05/23, 14:43

  15. Benni Mack voted on patch set 5 V +2 CR +2 04/05/23, 15:10

  16. Benni Mack merged patch set 6 04/05/23, 15:10