Review main Merged

78310[BUGFIX] Force correct type in ActionViewHelpers

Georg Ringer CR +2 V +2 Easy +10 −15 updated 06/07/23, 06:25

Commit message

Add several type casts to avoid notices.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1823

  1. Georg Ringer uploaded patch set 1 03/28/23, 18:20

  2. Georg Ringer commented on patch set 1 03/28/23, 18:20

    This change is ready for review.
  3. Oliver Klee voted on patch set 1 CR +1 03/28/23, 19:17

  4. core-ci voted on patch set 1 V -1 03/28/23, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39787

  5. Nikita Hovratov commented on patch set 1 03/28/23, 23:05

    ActionViewHelper.php:91

    There was a bugfix to not default this to null: https://review.typo3.org/c/Packages/TYPO3.CMS/+/53359 Can you check, if this is still valid?
  6. Nikita Hovratov commented on patch set 1 03/28/23, 23:06

    ActionViewHelper.php:91 Reply

    "not default this to 0" I mean.
  7. Benni Mack updated the commit message in patch set 2 CR +1 V -1 05/03/23, 09:41

  8. Torben Hansen commented on patch set 2 06/01/23, 07:04

    ActionViewHelper.php:99

    `addQueryString` can also be a string - see #100583

    ActionViewHelper.php:88

    `addQueryString` can also be a string - see #100583
  9. Torben Hansen uploaded patch set 3 06/01/23, 07:10

  10. Torben Hansen uploaded patch set 4 06/01/23, 07:12

  11. Torben Hansen commented on patch set 4 06/01/23, 07:14

    ActionViewHelper.php:91 Reply

    Good catch. I updated the patch

    ActionViewHelper.php:99 Reply

    Done

    ActionViewHelper.php:88 Reply

    Done
  12. core-ci voted on patch set 4 V +1 06/01/23, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42129

  13. core-ci voted on patch set 3 V -1 06/01/23, 07:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42128

  14. Torben Hansen updated the commit message in patch set 5 V +1 06/01/23, 07:27

  15. Oliver Klee voted on patch set 5 CR +1 06/01/23, 07:35

  16. core-ci voted on patch set 5 V +1 06/01/23, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42131

  17. Oli Bartsch commented on patch set 5 06/01/23, 09:00

    ActionViewHelper.php:96

    Should we add a null collapse operator here as well?

    ActionViewHelper.php:84

    According to the PHPDoc this should always be a bool. Should we therefore also add type cast here?
  18. Oli Bartsch uploaded patch set 6 CR +1 V +1 06/05/23, 09:24

  19. Oli Bartsch commented on patch set 6 V +1 CR +1 06/05/23, 09:25

    ActionViewHelper.php:96 Reply

    Done

    ActionViewHelper.php:84 Reply

    Done
  20. core-ci voted on patch set 6 V +1 06/05/23, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42213

  21. Oliver Klee voted on patch set 6 CR +1 06/05/23, 12:41

  22. Georg Ringer voted on patch set 6 V +2 CR +2 06/07/23, 06:25

  23. Georg Ringer merged patch set 7 06/07/23, 06:25