78310[BUGFIX] Force correct type in ActionViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1823
-
Georg Ringer uploaded patch set 1 03/28/23, 18:20
-
Georg Ringer commented on patch set 1 03/28/23, 18:20
This change is ready for review. -
Oliver Klee voted on patch set 1 CR +1 03/28/23, 19:17
-
core-ci voted on patch set 1 V -1 03/28/23, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39787
-
Nikita Hovratov commented on patch set 1 03/28/23, 23:05
ActionViewHelper.php:91There was a bugfix to not default this to null: https://review.typo3.org/c/Packages/TYPO3.CMS/+/53359 Can you check, if this is still valid? -
Nikita Hovratov commented on patch set 1 03/28/23, 23:06
ActionViewHelper.php:91Reply"not default this to 0" I mean. -
Benni Mack updated the commit message in patch set 2
CR +1V -105/03/23, 09:41 -
Torben Hansen commented on patch set 2 06/01/23, 07:04
ActionViewHelper.php:99`addQueryString` can also be a string - see #100583ActionViewHelper.php:88`addQueryString` can also be a string - see #100583 -
Torben Hansen uploaded patch set 3 06/01/23, 07:10
-
Torben Hansen uploaded patch set 4 06/01/23, 07:12
-
Torben Hansen commented on patch set 4 06/01/23, 07:14
ActionViewHelper.php:91ReplyGood catch. I updated the patchActionViewHelper.php:99ReplyDoneActionViewHelper.php:88ReplyDone -
core-ci voted on patch set 4 V +1 06/01/23, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42129
-
core-ci voted on patch set 3 V -1 06/01/23, 07:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42128
-
Torben Hansen updated the commit message in patch set 5
V +106/01/23, 07:27 -
Oliver Klee voted on patch set 5 CR +1 06/01/23, 07:35
-
core-ci voted on patch set 5 V +1 06/01/23, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42131
-
Oli Bartsch commented on patch set 5 06/01/23, 09:00
ActionViewHelper.php:96Should we add a null collapse operator here as well?ActionViewHelper.php:84According to the PHPDoc this should always be a bool. Should we therefore also add type cast here? -
Oli Bartsch uploaded patch set 6
CR +1V +106/05/23, 09:24 -
Oli Bartsch commented on patch set 6 V +1 CR +1 06/05/23, 09:25
ActionViewHelper.php:96ReplyDoneActionViewHelper.php:84ReplyDone -
core-ci voted on patch set 6 V +1 06/05/23, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42213
-
Oliver Klee voted on patch set 6 CR +1 06/05/23, 12:41
-
Georg Ringer voted on patch set 6 V +2 CR +2 06/07/23, 06:25
-
Georg Ringer merged patch set 7 06/07/23, 06:25