78315[TASK] Deprecate various functionality in legacy tree implementations
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php20+32 −2
- typo3/sysext/backend/Classes/Tree/View/BrowseTreeView.php+7 −0
- typo3/sysext/backend/Classes/Tree/View/ElementBrowserPageTreeView.php+2 −0
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+4 −2
- typo3/sysext/core/Documentation/Changelog/12.4/Deprecation-100454-LegacyTreeImplementations.rstnew+76 −0
- typo3/sysext/impexp/Classes/View/ExportPageTreeView.php+3 −2
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+3 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php5+10 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+35 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+10 −0
Review log 1825
-
Benni Mack uploaded patch set 1 03/29/23, 08:24
-
core-ci voted on patch set 1 V +1 03/29/23, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39807
-
Benni Mack updated the commit message in patch set 2
V +104/05/23, 07:33 -
core-ci voted on patch set 2 V +1 04/05/23, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40156
-
Benni Mack uploaded patch set 3
V +104/05/23, 08:09 -
core-ci voted on patch set 3 V -1 04/05/23, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40158
-
Benni Mack uploaded patch set 4
V -104/05/23, 08:43 -
core-ci voted on patch set 4 V +1 04/05/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40163
-
Benni Mack uploaded patch set 5
V +104/05/23, 09:15 -
core-ci voted on patch set 5 V +1 04/05/23, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40166
-
Benni Mack commented on patch set 6
V +104/05/23, 10:24Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 04/05/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40175
-
Oliver Klee voted on patch set 6 CR +1 04/05/23, 12:04
-
Christian Kuhn commented on patch set 6 04/05/23, 12:09
ClassNameMatcher.php:2266? -
Oli Bartsch commented on patch set 6 CR -1 04/05/23, 12:13
AbstractTreeView.php:60I suggest to either remove this or also add it for $thisScriptAbstractTreeView.php:86marked as protected in TYPO3 v13.0AbstractTreeView.php:95marked as protected in TYPO3 v13.0AbstractTreeView.php:105marked as protected in TYPO3 v13.0AbstractTreeView.php:132marked as protected in TYPO3 v13.0AbstractTreeView.php:189Could we just duplicate the code for now to enable deprecation log entries?AbstractTreeView.php:204Could we just duplicate the code for now to enable deprecation log entries?AbstractTreeView.php:285will be marked as protected?AbstractTreeView.php:527Extension scanner coverage missing for this methodClassNameMatcher.php:2266Is this entry removed on purpose? -
Benni Mack commented on patch set 6 04/05/23, 12:21
AbstractTreeView.php:60Replynope. BE_USER is not in use, but $thisScript is.AbstractTreeView.php:189Replygood ideaClassNameMatcher.php:2266Replyfail from my side -
Oli Bartsch uploaded patch set 7
CR +1V +104/05/23, 17:22 -
Oli Bartsch commented on patch set 7 04/05/23, 17:23
AbstractTreeView.php:60ReplyAckAbstractTreeView.php:86ReplyDoneAbstractTreeView.php:95ReplyDoneAbstractTreeView.php:105ReplyDoneAbstractTreeView.php:132ReplyDoneAbstractTreeView.php:189ReplyDoneAbstractTreeView.php:204ReplyDoneAbstractTreeView.php:285ReplyDoneAbstractTreeView.php:527ReplyDoneClassNameMatcher.php:2266ReplyDone -
Oli Bartsch commented on patch set 7 04/05/23, 17:24
ClassNameMatcher.php:2266ReplyDone -
core-ci voted on patch set 7 V +1 04/05/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40205
-
Benni Mack commented on patch set 7 V +1 CR +1 04/05/23, 21:00
thanks for cleaning this up! -
Oli Bartsch voted on patch set 7 V +1 CR +1 04/05/23, 21:18
-
Christian Kuhn voted on patch set 7 V +1 CR +1 04/05/23, 21:44
-
Oli Bartsch voted on patch set 7 V +2 CR +2 04/06/23, 07:07
-
Oli Bartsch merged patch set 8 04/06/23, 07:07