Review main Merged

78315[TASK] Deprecate various functionality in legacy tree implementations

Benni Mack CR +2 V +2 Normal +182 −7 updated 04/06/23, 07:07

Commit message

This patch deprecates all old-style tree views
that have been in use for over 15 years now without
larger refactoring.

As we now use the web-component-based tree in most
places, these class and properties can now
be deprecated, in order to phase out old logic.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1825

  1. Benni Mack uploaded patch set 1 03/29/23, 08:24

  2. core-ci voted on patch set 1 V +1 03/29/23, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39807

  3. Benni Mack updated the commit message in patch set 2 V +1 04/05/23, 07:33

  4. core-ci voted on patch set 2 V +1 04/05/23, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40156

  5. Benni Mack uploaded patch set 3 V +1 04/05/23, 08:09

  6. core-ci voted on patch set 3 V -1 04/05/23, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40158

  7. Benni Mack uploaded patch set 4 V -1 04/05/23, 08:43

  8. core-ci voted on patch set 4 V +1 04/05/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40163

  9. Benni Mack uploaded patch set 5 V +1 04/05/23, 09:15

  10. core-ci voted on patch set 5 V +1 04/05/23, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40166

  11. Benni Mack commented on patch set 6 V +1 04/05/23, 10:24

    Published edit on patch set 5.
  12. core-ci voted on patch set 6 V +1 04/05/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40175

  13. Oliver Klee voted on patch set 6 CR +1 04/05/23, 12:04

  14. Christian Kuhn commented on patch set 6 04/05/23, 12:09

    ClassNameMatcher.php:2266

    ?
  15. Oli Bartsch commented on patch set 6 CR -1 04/05/23, 12:13

    AbstractTreeView.php:60

    I suggest to either remove this or also add it for $thisScript

    AbstractTreeView.php:86

    marked as protected in TYPO3 v13.0

    AbstractTreeView.php:95

    marked as protected in TYPO3 v13.0

    AbstractTreeView.php:105

    marked as protected in TYPO3 v13.0

    AbstractTreeView.php:132

    marked as protected in TYPO3 v13.0

    AbstractTreeView.php:189

    Could we just duplicate the code for now to enable deprecation log entries?

    AbstractTreeView.php:204

    Could we just duplicate the code for now to enable deprecation log entries?

    AbstractTreeView.php:285

    will be marked as protected?

    AbstractTreeView.php:527

    Extension scanner coverage missing for this method

    ClassNameMatcher.php:2266

    Is this entry removed on purpose?
  16. Benni Mack commented on patch set 6 04/05/23, 12:21

    AbstractTreeView.php:60 Reply

    nope. BE_USER is not in use, but $thisScript is.

    AbstractTreeView.php:189 Reply

    good idea

    ClassNameMatcher.php:2266 Reply

    fail from my side
  17. Oli Bartsch uploaded patch set 7 CR +1 V +1 04/05/23, 17:22

  18. Oli Bartsch commented on patch set 7 04/05/23, 17:23

    AbstractTreeView.php:60 Reply

    Ack

    AbstractTreeView.php:86 Reply

    Done

    AbstractTreeView.php:95 Reply

    Done

    AbstractTreeView.php:105 Reply

    Done

    AbstractTreeView.php:132 Reply

    Done

    AbstractTreeView.php:189 Reply

    Done

    AbstractTreeView.php:204 Reply

    Done

    AbstractTreeView.php:285 Reply

    Done

    AbstractTreeView.php:527 Reply

    Done

    ClassNameMatcher.php:2266 Reply

    Done
  19. Oli Bartsch commented on patch set 7 04/05/23, 17:24

    ClassNameMatcher.php:2266 Reply

    Done
  20. core-ci voted on patch set 7 V +1 04/05/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40205

  21. Benni Mack commented on patch set 7 V +1 CR +1 04/05/23, 21:00

    thanks for cleaning this up!
  22. Oli Bartsch voted on patch set 7 V +1 CR +1 04/05/23, 21:18

  23. Christian Kuhn voted on patch set 7 V +1 CR +1 04/05/23, 21:44

  24. Oli Bartsch voted on patch set 7 V +2 CR +2 04/06/23, 07:07

  25. Oli Bartsch merged patch set 8 04/06/23, 07:07