Review main Merged

78316[TASK] Remove duplicate label for "Language"

Nikita Hovratov CR +2 V +2 Easy +1 −4 updated 03/29/23, 09:31

Commit message

Only the table "tt_content" overrides the label for the sys_language_uid
field on palette level with
"EXT:frontend/.../locallang_ttc.xlf:sys_language_uid_formlabel".
However, this label is exactly the same as
"EXT:core/.../locallang_general.xlf:LGL.language". Therefore, the first
mentioned label is removed in favour of the original one.

Note: The second label was probably introduced in 2010 when the original
field contained "Language:" (with colons at the end). This has been
removed in the meantime.

See commit: b6fb9732

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Nikita Hovratov uploaded patch set 1 03/29/23, 08:49

  2. Nikita Hovratov updated the commit message in patch set 2 03/29/23, 08:50

  3. core-ci voted on patch set 1 V +1 03/29/23, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39809

  4. core-ci voted on patch set 2 V +1 03/29/23, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39810

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 03/29/23, 09:16

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 03/29/23, 09:31

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 03/29/23, 09:31

  8. Christian Kuhn merged patch set 3 03/29/23, 09:31