Review main Merged

78319[BUGFIX] Fix some incorrect types in Extbase

Oliver Klee CR +2 V +2 Easy +9 −9 updated 03/29/23, 17:12

Commit message

Add some type casts that are necessary in order to make the internal
Extbase classes strict.

Also complete some incomplete (and hence incorrect) return type
annotations.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Oliver Klee uploaded patch set 1 03/29/23, 11:08

  2. core-ci voted on patch set 1 V +1 03/29/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39816

  3. Oliver Klee wrote 03/29/23, 11:20

    Topic set to extbase
  4. Oliver Klee uploaded patch set 2 V +1 03/29/23, 11:29

  5. core-ci voted on patch set 2 V +1 03/29/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39820

  6. Christian Kuhn updated the commit message in patch set 3 V +1 03/29/23, 16:36

  7. Christian Kuhn commented on patch set 3 03/29/23, 16:37

    gives headaches in v11, sticking to main only.
  8. Christian Kuhn rebased onto patch set 4 03/29/23, 16:37

  9. Oliver Klee commented on patch set 4 03/29/23, 16:41

    Reply

    Ack
  10. core-ci voted on patch set 3 V +1 03/29/23, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39835

  11. core-ci voted on patch set 4 V +1 03/29/23, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39836

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 03/29/23, 17:10

  13. Stefan Bürk voted on patch set 4 V +2 CR +2 03/29/23, 17:12

  14. Stefan Bürk merged patch set 5 03/29/23, 17:12