Review main Merged

78321[TASK] Deprecate BackendUtility::getRecordToolTip()

Benni Mack CR +2 V +2 Normal +73 −16 updated 04/05/23, 12:17

Commit message

This method is just a wrapper for a title=""
attribute and is very inflexible. Thus, it is marked
as deprecated.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 911

  1. Benni Mack uploaded patch set 1 03/29/23, 13:02

  2. core-ci voted on patch set 1 V +1 03/29/23, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39825

  3. Georg Ringer commented on patch set 1 03/29/23, 20:42

    GridColumnItem.php:177

    just looks wrong having a method with *alt* for a title field
  4. Benni Mack commented on patch set 1 03/30/23, 08:37

    GridColumnItem.php:177 Reply

    totally. I also think we should include a non-hsc-ed alternative to that method (that we could then give it a better naming) but... separate step.
  5. Benni Mack uploaded patch set 2 V +1 04/05/23, 08:31

  6. Oliver Klee voted on patch set 2 CR +1 04/05/23, 08:38

  7. core-ci voted on patch set 2 V +1 04/05/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40161

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 04/05/23, 11:10

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 04/05/23, 12:11

  10. Oli Bartsch voted on patch set 2 V +2 CR +2 04/05/23, 12:17

  11. Oli Bartsch merged patch set 3 04/05/23, 12:17