Review main Merged

78323[BUGFIX] Date ViewHelper should use strftime() method

Benni Mack CR +2 V +2 Easy +11 −1 updated 03/29/23, 15:15

Commit message

When having a % in the format,
the strftime() method should be used
from the DateFormatter.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1113

  1. Benni Mack uploaded patch set 1 03/29/23, 13:52

  2. Oliver Klee voted on patch set 1 CR +1 03/29/23, 13:54

  3. core-ci voted on patch set 1 V +1 03/29/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39827

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 03/29/23, 14:06

  5. Christian Kuhn commented on patch set 1 CR -1 03/29/23, 14:34

    let's add a functional test for this while we are at it. i'll see if i can come up with something.
  6. Christian Kuhn uploaded patch set 2 CR +1 V +1 03/29/23, 14:46

  7. Christian Kuhn commented on patch set 2 03/29/23, 14:46

    added regression test and relation to offending patch.
  8. Oliver Klee voted on patch set 2 CR +1 03/29/23, 14:51

  9. core-ci voted on patch set 2 V +1 03/29/23, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39831

  10. Oliver Klee voted on patch set 2 V +1 03/29/23, 14:54

  11. Christian Kuhn voted on patch set 2 V +1 CR +1 03/29/23, 15:15

  12. Stefan Bürk voted on patch set 2 V +2 CR +2 03/29/23, 15:15

  13. Stefan Bürk merged patch set 3 03/29/23, 15:15