Review main Merged

78324[TASK] Do not accept empty password in backend password reset

Torben Hansen CR +2 V +2 Easy +6 −1 updated 03/29/23, 18:11

Commit message

If the global password policy has been disabled and the backend
password function is used, it is possible to submit an empty
password, if the user manually removes the `required` attribute
from the password fields in the password reset form.

This change ensures, that an empty password will not be accepted
by the backend password reset function.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Torben Hansen uploaded patch set 1 03/29/23, 13:55

  2. core-ci voted on patch set 1 V +1 03/29/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39828

  3. Andreas Kienast voted on patch set 1 CR +1 03/29/23, 15:17

  4. Oliver Klee commented on patch set 1 03/29/23, 15:21

    PasswordReset.php:334

    I'd prefer to have two different log messages for this so the cause of a failure is easier to determine going by the logs.
  5. Torben Hansen uploaded patch set 2 CR +1 V +1 03/29/23, 17:54

  6. Torben Hansen commented on patch set 1 03/29/23, 17:54

    PasswordReset.php:334 Reply

    Done
  7. Andreas Kienast voted on patch set 2 V +1 CR +1 03/29/23, 17:59

  8. core-ci voted on patch set 2 V +1 03/29/23, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39841

  9. Oliver Klee voted on patch set 2 CR +1 03/29/23, 18:01

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 03/29/23, 18:11

  11. Christian Kuhn merged patch set 3 03/29/23, 18:11