78325[BUGFIX] Ensure translate ViewHelper uses site language locale
Commit message
Review
-
Code review CR +2 Done
- Kevin Appelt +2
- Marc Willmann +1
-
Verified V +2 Done
- Kevin Appelt +2
- Marc Willmann +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1117
-
Benni Mack uploaded patch set 1 03/29/23, 15:05
-
Benni Mack updated the commit message in patch set 2 03/29/23, 15:15
-
core-ci voted on patch set 1 V -1 03/29/23, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39832
-
core-ci voted on patch set 2 V -1 03/29/23, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39833
-
Georg Ringer commented on patch set 2 03/29/23, 20:44
in which use cases do we have not site language and wouldn't it be better to just fallback to english? I can imagine that having such edge cases it doesn't help to get random variants based on the configured user language -
Benni Mack commented on patch set 2 03/30/23, 06:48
Reply
this is in Backend context, where we don't have a site language. createFromUserPreferences() also falls back to english again if there is no BE_USER. -
Benni Mack uploaded patch set 3
V -104/04/23, 08:10 -
core-ci voted on patch set 3 V +1 04/04/23, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40058
-
Benni Mack updated the commit message in patch set 4
V +104/04/23, 12:46 -
core-ci voted on patch set 4 V +1 04/04/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40086
-
Benni Mack updated the commit message in patch set 5
V +104/04/23, 13:05 -
Oliver Klee updated the commit message in patch set 6 04/04/23, 13:11
-
core-ci voted on patch set 5 V +1 04/04/23, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40087
-
core-ci voted on patch set 6 V +1 04/04/23, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40088
-
Marc Willmann commented on patch set 6 V +1 CR +1 04/04/23, 13:36
Fixes https://forge.typo3.org/issues/100255 Thanks for caring. :) -
Kevin Appelt voted on patch set 6 V +2 CR +2 04/04/23, 13:39
-
Kevin Appelt merged patch set 7 04/04/23, 13:39