Review main Merged

78326[BUGFIX] Check if requested start module is registered before resolution

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 03/29/23, 18:09

Commit message

The change in #100342 was not complete and might lead to exceptions
when a regular route name not matching a module is passed as the
start module, e.g. when reloading the browser while
EditDocumentController is open.

This is now guarded by a check whether whatever is coming in is an
actual registered module before attempting to resolve potential module
aliases.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Andreas Kienast uploaded patch set 1 03/29/23, 17:48

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 03/29/23, 18:04

  3. core-ci voted on patch set 1 V +1 03/29/23, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39840

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 03/29/23, 18:09

  5. Stefan Bürk merged patch set 2 03/29/23, 18:09