Review main Merged

78328[BUGFIX] Drop obsolete `table-wizard` module

Andreas Kienast CR +2 V +2 Normal +0 −53 updated 03/30/23, 08:21

Commit message

The FormEngine JavaScript module `table-wizard` became obsolete with
ticket #95036 and was forgotten to be removed, which is now done.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Andreas Kienast uploaded patch set 1 03/30/23, 07:52

  2. Mathias Brodala commented on patch set 1 03/30/23, 07:57

    Maybe add more details here?
  3. core-ci voted on patch set 1 V +1 03/30/23, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39854

  4. Andreas Kienast commented on patch set 1 03/30/23, 08:01

    Reply

    Nice. I use vim to write commit messages and the missing line started with the related ticket number. Obviously, it was interpreted as a comment m(.
  5. Andreas Kienast updated the commit message in patch set 2 V +1 03/30/23, 08:02

  6. Andreas Kienast commented on patch set 2 03/30/23, 08:02

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 03/30/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39855

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 03/30/23, 08:10

  9. Benni Mack voted on patch set 2 V +1 CR +1 03/30/23, 08:11

  10. Oliver Klee voted on patch set 2 CR +1 03/30/23, 08:11

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 03/30/23, 08:21

  12. Andreas Kienast merged patch set 3 03/30/23, 08:21