78331[BUGFIX] Support @import 'EXT:.../TypoScript/*.setup.typoscript'
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 4
Files 8
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php3+18 −9
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97816-TypoScriptSyntaxChanges.rst2+84 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97816-TypoScriptSyntaxImprovements.rst+3 −3
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario4/file1.setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario4/file2.setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario4/file3.notIncluded.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php+22 −1
- typo3/sysext/felogin/Documentation/Examples/Index.rst+1 −1
Review log 1214
-
Christian Kuhn uploaded patch set 1 03/30/23, 11:07
-
Christian Kuhn uploaded patch set 2 03/30/23, 11:10
-
Christian Kuhn uploaded patch set 3 03/30/23, 11:13
-
core-ci voted on patch set 3 V +1 03/30/23, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39865
-
Christian Kuhn uploaded patch set 4
V +103/30/23, 11:24 -
core-ci voted on patch set 4 V +1 03/30/23, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39866
-
Stefan Bürk commented on patch set 4 03/30/23, 11:55
-
Stefan Bürk commented on patch set 4 03/30/23, 11:59
TreeFromLineStreamBuilder.php:326nitpicking, but .. should we not avoid using "prefix" here for the variable names and instead use: ``` $leftPartFromWildcard $rightPartFromWildcard // or $rightPartFromWildcardWithFileSuffix ``` I guess this would make it easier in the future if looking into these lines. but fine keeping currently variable names. -
Stefan Bürk voted on patch set 4 V +1 CR +1 03/30/23, 11:59
-
Christian Kuhn commented on patch set 4 03/30/23, 12:14
TreeFromLineStreamBuilder.php:326Replyi renamed those twice already and came back to $leftPrefix / $rightPrefix again. i think this matches the content of these variables pretty well. let's keep it.Breaking-97816-TypoScriptSyntaxChanges.rst:171Replyi hope that's obvious enough already, and technically correct. the examples below show according scenarios. -
Nikita Hovratov voted on patch set 4 V +1 CR +1 03/30/23, 12:40
-
Benni Mack commented on patch set 4 03/30/23, 13:12
TreeFromLineStreamBuilder.php:326Replylet's keep in mind to extract this logic in some more generic place at some point in our lives. Otherwise, fine by me -
Christian Kuhn voted on patch set 4 V +2 CR +2 03/30/23, 15:10
-
Christian Kuhn merged patch set 5 03/30/23, 15:10
Breaking-97816-TypoScriptSyntaxChanges.rst:171