78332[BUGFIX] Allow DI for OnlineMediaController
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Jochen Roth uploaded patch set 1 03/30/23, 11:44
-
core-ci voted on patch set 1 V +1 03/30/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39867
-
Andreas Kienast voted on patch set 1 V +1 CR +1 03/30/23, 12:02
-
Christian Kuhn commented on patch set 1 03/30/23, 12:26
since it's a controller: use #[Controller] attribute and skip the Services.yaml change? -
Jochen Roth uploaded patch set 2
CR +1V +103/30/23, 12:45 -
Jochen Roth commented on patch set 2 03/30/23, 12:46
Reply
Done -
core-ci voted on patch set 2 V +1 03/30/23, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39869
-
Andreas Kienast voted on patch set 2 V +1 CR +1 03/30/23, 13:26
-
Christian Kuhn commented on patch set 2 03/30/23, 15:07
commit message not up-to-date ;) -
Christian Kuhn updated the commit message in patch set 3
CR +1V +103/30/23, 15:08 -
Christian Kuhn commented on patch set 3 03/30/23, 15:09
Reply
Done -
Christian Kuhn voted on patch set 3 V +1 CR +1 03/30/23, 15:09
-
core-ci voted on patch set 3 V +1 03/30/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39872
-
Georg Ringer voted on patch set 3 V +2 CR +2 03/30/23, 19:33
-
Georg Ringer merged patch set 4 03/30/23, 19:33