Review main Merged

78332[BUGFIX] Allow DI for OnlineMediaController

Jochen Roth CR +2 V +2 Easy +2 −0 updated 03/30/23, 19:33

Commit message

Currently an error is thrown when trying to create
a online media resource.

This has been fixed by adding the controller
attribute.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Jochen Roth uploaded patch set 1 03/30/23, 11:44

  2. core-ci voted on patch set 1 V +1 03/30/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39867

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 03/30/23, 12:02

  4. Christian Kuhn commented on patch set 1 03/30/23, 12:26

    since it's a controller: use #[Controller] attribute and skip the Services.yaml change?
  5. Jochen Roth uploaded patch set 2 CR +1 V +1 03/30/23, 12:45

  6. Jochen Roth commented on patch set 2 03/30/23, 12:46

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 03/30/23, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39869

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 03/30/23, 13:26

  9. Christian Kuhn commented on patch set 2 03/30/23, 15:07

    commit message not up-to-date ;)
  10. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 03/30/23, 15:08

  11. Christian Kuhn commented on patch set 3 03/30/23, 15:09

    Reply

    Done
  12. Christian Kuhn voted on patch set 3 V +1 CR +1 03/30/23, 15:09

  13. core-ci voted on patch set 3 V +1 03/30/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39872

  14. Georg Ringer voted on patch set 3 V +2 CR +2 03/30/23, 19:33

  15. Georg Ringer merged patch set 4 03/30/23, 19:33