78333[BUGFIX] Migrate Site TCA Configuration
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Chris Müller +1
-
Verified V +2 Done
- Oli Bartsch +2
- Chris Müller +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Nikita Hovratov uploaded patch set 1 03/30/23, 12:29
-
Georg Ringer voted on patch set 1 CR +1 03/30/23, 12:37
-
core-ci voted on patch set 1 V +1 03/30/23, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39868
-
Chris Müller voted on patch set 1 V +1 CR +1 03/30/23, 13:03
-
Oli Bartsch commented on patch set 1 04/03/23, 10:42
-
Nikita Hovratov commented on patch set 1 04/03/23, 15:10
SiteTcaConfiguration.php:83ReplyI don't think this is needed, but if you think otherwise go ahead and push another patch set. I'm in vacation now and won't be able to adjust it. -
Oli Bartsch uploaded patch set 2
CR +1V +104/03/23, 15:34 -
Oli Bartsch commented on patch set 2 V +1 CR +1 04/03/23, 15:36
SiteTcaConfiguration.php:83ReplyYes, but even if this is internal we might just use makeInstance for consistence. Adjusted the patch accordingly. -
core-ci voted on patch set 2 V +1 04/03/23, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40025
-
Chris Müller voted on patch set 2 V +1 CR +1 04/03/23, 18:50
-
Oli Bartsch voted on patch set 2 V +2 CR +2 04/04/23, 09:03
-
Oli Bartsch merged patch set 3 04/04/23, 09:03
SiteTcaConfiguration.php:83