Review main Merged

78333[BUGFIX] Migrate Site TCA Configuration

Nikita Hovratov CR +2 V +2 Easy +11 −0 updated 04/04/23, 09:03

Commit message

Until now, the TCA for Site Configuration was never migrated by the
TcaMigrator. With the massive amount of TCA deprecations, an error
popped up eventually. The gathered TCA overrides are now migrated and
will log deprecation level log entries, just like the standard TCA
migration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Chris Müller +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Nikita Hovratov uploaded patch set 1 03/30/23, 12:29

  2. Georg Ringer voted on patch set 1 CR +1 03/30/23, 12:37

  3. core-ci voted on patch set 1 V +1 03/30/23, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39868

  4. Chris Müller voted on patch set 1 V +1 CR +1 03/30/23, 13:03

  5. Oli Bartsch commented on patch set 1 04/03/23, 10:42

    SiteTcaConfiguration.php:83

    Any reason for not using GU::makeInstance like done at the other usages in Core?
  6. Nikita Hovratov commented on patch set 1 04/03/23, 15:10

    SiteTcaConfiguration.php:83 Reply

    I don't think this is needed, but if you think otherwise go ahead and push another patch set. I'm in vacation now and won't be able to adjust it.
  7. Oli Bartsch uploaded patch set 2 CR +1 V +1 04/03/23, 15:34

  8. Oli Bartsch commented on patch set 2 V +1 CR +1 04/03/23, 15:36

    SiteTcaConfiguration.php:83 Reply

    Yes, but even if this is internal we might just use makeInstance for consistence. Adjusted the patch accordingly.
  9. core-ci voted on patch set 2 V +1 04/03/23, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40025

  10. Chris Müller voted on patch set 2 V +1 CR +1 04/03/23, 18:50

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 04/04/23, 09:03

  12. Oli Bartsch merged patch set 3 04/04/23, 09:03