Review main Merged

78336[BUGFIX] Handle uploaded files in EXT:form

Andreas Kienast CR +2 V +2 Easy +17 −2 updated 04/18/23, 12:41

Commit message

With the migration to native ServerRequestInterface, EXT:form isn't
able to detect uploaded files anymore. The `arguments` property from
the underlying Extbase request object is obtained, which contains
information about uploaded files in a wrong structure.
Therefore, the arguments are merged with the uploaded files array
instead.

Since uploaded files are converted to a `UploadedFile` object,
EXT:form's `UploadedFileReferenceConverter` is adapted to be able to
handle said objects as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Kevin Appelt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Kevin Appelt +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Andreas Kienast uploaded patch set 1 03/31/23, 09:10

  2. core-ci voted on patch set 1 V +1 03/31/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39896

  3. Andreas Kienast commented on patch set 1 CR -1 03/31/23, 10:18

  4. Andreas Kienast uploaded patch set 2 CR -1 V +1 04/03/23, 06:57

  5. core-ci voted on patch set 2 V +1 04/03/23, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40001

  6. Kevin Appelt commented on patch set 2 V +1 CR +1 04/12/23, 07:46

    The problem of missing uploaded files is fixed with this.
  7. Benni Mack commented on patch set 2 04/12/23, 11:26

    We might add a note on how to migrate in the 12.0 RST where we switched from $_FILES to Psr-7?
  8. Kevin Appelt commented on patch set 2 04/16/23, 08:13

    Reply

    What do you mean by "how to migrate"? As a user, I don't have to make any adjustments, or am I missing something?
  9. Benni Mack commented on patch set 2 04/18/23, 09:29

    Reply

    I thought that other people might also have this problem with their own UploadedFileReferenceConverter - could be done in a separate change
  10. Benni Mack voted on patch set 2 V +2 CR +2 04/18/23, 12:41

  11. Benni Mack merged patch set 3 04/18/23, 12:41