Review main Merged

78338[BUGFIX] Avoid error for orphaned ts templates

Christian Eßl CR +2 V +2 Easy +4 −1 updated 04/03/23, 08:54

Commit message

When a page containing a typoscript template has been
deleted, there won't be a valid rootline for the template.
Add a simple check to avoid an "undefined array key" error.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Christian Eßl uploaded patch set 1 03/31/23, 14:19

  2. Christian Eßl updated the commit message in patch set 2 03/31/23, 14:19

  3. core-ci voted on patch set 1 V +1 03/31/23, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39904

  4. core-ci voted on patch set 2 V +1 03/31/23, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39905

  5. Oliver Klee commented on patch set 2 03/31/23, 16:27

    TemplateRecordsOverviewController.php:94

    To make it known to PHPStan that this method may only be called with a non-empty array, let's add a type annotation: `@param non-empty-array $rootline`
  6. Markus Klein commented on patch set 3 V +1 03/31/23, 22:09

    Published edit on patch set 2.
  7. Markus Klein commented on patch set 3 V +1 CR +1 03/31/23, 22:09

    TemplateRecordsOverviewController.php:94 Reply

    Done
  8. core-ci voted on patch set 3 V +1 03/31/23, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39919

  9. Oliver Klee voted on patch set 3 CR +1 03/31/23, 22:21

  10. Benni Mack voted on patch set 3 CR +1 04/03/23, 08:46

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 04/03/23, 08:54

  12. Christian Kuhn merged patch set 4 04/03/23, 08:54