Review main Merged

78344[TASK] Superfluous SQL query in language menu

Christoph Lehmann CR +2 V +2 Easy +1 −1 updated 04/11/23, 09:46

Commit message

TSFE->page now holds a copy of the page in default language, so it
can be re-used.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1217

  1. Christoph Lehmann uploaded patch set 1 03/31/23, 20:23

  2. core-ci voted on patch set 1 V +1 03/31/23, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39915

  3. Christoph Lehmann updated the commit message in patch set 2 V +1 04/02/23, 14:26

  4. core-ci voted on patch set 2 V +1 04/02/23, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39988

  5. Benni Mack voted on patch set 2 V +1 CR +1 04/03/23, 13:19

  6. Oli Bartsch commented on patch set 2 04/04/23, 09:47

    AbstractMenuContentObject.php:571

    Could we make this more strict by using: ($tsfe->page['_TRANSLATION_SOURCE'] ?? null) instanceof Page
  7. Oli Bartsch commented on patch set 2 04/04/23, 10:10

    AbstractMenuContentObject.php:571 Reply

    We might even use a one-liner: ($tsfe->page['_TRANSLATION_SOURCE'] ?? null)?->toArray(true) ?? $tsfe->page;
  8. Christoph Lehmann uploaded patch set 3 CR +1 V +1 04/04/23, 17:50

  9. Christoph Lehmann commented on patch set 2 04/04/23, 17:52

    AbstractMenuContentObject.php:571 Reply

    I'm fine with the oneline. The instanceof has a bad touch, because it possibly eats an Exception and then leads to wrong behaviour.
  10. core-ci voted on patch set 3 V +1 04/04/23, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40110

  11. Christoph Lehmann uploaded patch set 4 V +1 04/10/23, 20:18

  12. Christoph Lehmann commented on patch set 5 04/10/23, 20:31

    Published edit on patch set 4.
  13. core-ci voted on patch set 4 V +1 04/10/23, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40423

  14. core-ci voted on patch set 5 V +1 04/10/23, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40431

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 04/11/23, 06:57

  16. Benni Mack voted on patch set 5 V +2 CR +2 04/11/23, 09:46

  17. Benni Mack merged patch set 6 04/11/23, 09:46