Review main Merged

78346[TASK] Respect usePasswordPolicyForFrontendUsers in TCA type=password

Torben Hansen CR +2 V +2 Easy +16 −0 updated 04/18/23, 14:15

Commit message

The feature toggle `security.usePasswordPolicyForFrontendUsers`
introduced in #97390 was added to allow TYPO3 administrators to
still use the deprecated TypoScript validators in ext:felogin
for the password reset process. In order to have a consistent
setup, the feature toggle must also be respected for frontend
users in DataHandler and FormEngine, so it is possible to set
any password, if the feature is turned off.

With this patch, a possible configured password policy for frontend
context (fe_users table) is ignored, if
`security.usePasswordPolicyForFrontendUsers` is set to `false`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Torben Hansen uploaded patch set 1 04/01/23, 04:48

  2. core-ci voted on patch set 1 V +1 04/01/23, 04:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39927

  3. Oli Bartsch commented on patch set 1 04/03/23, 10:52

    DataHandler.php:1869

    Could we cover this with a test?
  4. Torben Hansen commented on patch set 1 04/03/23, 16:59

    DataHandler.php:1869 Reply

    Basically we could, but it does not make much sense IMO, since the feature toggle "security.usePasswordPolicyForFrontendUsers" will be removed in v13 again ( deprecated TypoScript validators in ext:felogin are removed, which were reason for the feature toggle).
  5. Oli Bartsch commented on patch set 1 V +1 CR +1 04/04/23, 09:41

    DataHandler.php:1869 Reply

    OK
  6. Benni Mack voted on patch set 1 V +2 CR +2 04/18/23, 14:15

  7. Benni Mack merged patch set 2 04/18/23, 14:15