Review main Merged

78354[TASK] Speed up page tree

Christian Eßl CR +2 V +2 Normal +58 −59 updated 04/12/23, 04:41

Commit message

Further speed up the page tree for large sites by initially preparing
the quoted fields instead of newly quoting them for each single db
query.

Test scenario:
- 160 sites (page trees)
- Each site has 30 pages on the first two levels, divided into 5
  branches.
- Rendering time of tree ~9.8s
- Of those, 1.8s is just for repeatedly quoting the same field array.

Also introduce stricter typing to the class, primarily to make
clear, that the fields array must not be modified after construction.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Christian Eßl uploaded patch set 1 04/01/23, 20:27

  2. core-ci voted on patch set 1 V +1 04/01/23, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39945

  3. Christian Eßl updated the commit message in patch set 2 V +1 04/01/23, 21:07

  4. core-ci voted on patch set 2 V +1 04/01/23, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39946

  5. Stephan Großberndt voted on patch set 2 CR +1 04/02/23, 07:25

  6. Christoph Lehmann voted on patch set 2 CR +1 04/02/23, 10:47

  7. Christian Eßl uploaded patch set 3 CR +1 V +1 04/02/23, 11:17

  8. core-ci voted on patch set 3 V +1 04/02/23, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39967

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 04/11/23, 17:21

  10. Oliver Klee voted on patch set 3 V +1 CR +1 04/11/23, 18:18

  11. Georg Ringer voted on patch set 3 V +2 CR +2 04/12/23, 04:41

  12. Georg Ringer merged patch set 4 04/12/23, 04:41