Review main Merged

78359[TASK] Split a non-static data provider

Christian Kuhn CR +2 V +2 Normal +50 −14 updated 04/02/23, 13:24

Commit message

Splitting the data provider that uses $this
to create mocks into single tests is the
easiest solution, even though it duplicates
code a bit.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 04/02/23, 09:07

  2. core-ci voted on patch set 1 V -1 04/02/23, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39959

  3. Christian Kuhn uploaded patch set 2 V -1 04/02/23, 10:31

  4. core-ci voted on patch set 2 V +1 04/02/23, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39962

  5. Oliver Klee voted on patch set 2 V +1 04/02/23, 10:46

  6. Oliver Klee voted on patch set 2 CR +1 04/02/23, 10:47

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 04/02/23, 13:24

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 04/02/23, 13:24

  9. Christian Kuhn merged patch set 3 04/02/23, 13:24