Review main Merged

78360[TASK] Turn CleanerFieldProviderTest into funcional test

Christian Kuhn CR +2 V +2 Hard +119 −179 updated 04/02/23, 13:35

Commit message

Avoid a mocking party, static data providers,
move another test to proper namespace.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 79

  1. Christian Kuhn uploaded patch set 1 04/02/23, 10:31

  2. core-ci voted on patch set 1 V -1 04/02/23, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39961

  3. Christian Kuhn uploaded patch set 2 V -1 04/02/23, 10:55

  4. core-ci voted on patch set 2 V +1 04/02/23, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39965

  5. Oliver Klee voted on patch set 2 V +1 04/02/23, 11:47

  6. Oliver Klee voted on patch set 2 CR +1 04/02/23, 11:47

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 04/02/23, 13:35

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 04/02/23, 13:35

  9. Christian Kuhn merged patch set 3 04/02/23, 13:35