Review main Merged

78362[TASK] Have static DP in ContentObjectRendererTest

Christian Kuhn CR +2 V +2 Hard +194 −222 updated 04/02/23, 13:27

Commit message

Clean up a bit along the way and avoid
a useless trait.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/02/23, 10:51

  2. Oliver Klee commented on patch set 1 04/02/23, 11:01

    ContentObjectRendererTest.php:108

    Please let's have the "real" class first for consistency: `CacheManager&MockObject`
  3. core-ci voted on patch set 1 V -1 04/02/23, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39964

  4. Christian Kuhn commented on patch set 1 04/02/23, 11:33

    ContentObjectRendererTest.php:108 Reply

    Done
  5. Christian Kuhn uploaded patch set 2 V -1 04/02/23, 11:34

  6. core-ci voted on patch set 2 V +1 04/02/23, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39969

  7. Oliver Klee voted on patch set 2 V +1 CR +1 04/02/23, 11:45

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 04/02/23, 13:27

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 04/02/23, 13:27

  10. Christian Kuhn merged patch set 3 04/02/23, 13:27