Review main Merged

78364[TASK] Have static DP in PropertyMappingConfigurationTest

Christian Kuhn CR +2 V +2 Normal +95 −101 updated 04/02/23, 13:30

Commit message

Split the offending data provider to avoid
creating mocks within it. Clean up along
the way a bit.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 04/02/23, 11:31

  2. core-ci voted on patch set 1 V +1 04/02/23, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39968

  3. Oliver Klee voted on patch set 1 V +1 CR +1 04/02/23, 11:46

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 04/02/23, 13:29

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/02/23, 13:30

  6. Christian Kuhn merged patch set 2 04/02/23, 13:30