Review main Merged

78368[TASK] Have static DP in VimeoHelperTest

Christian Kuhn CR +2 V +2 Normal +22 −42 updated 04/02/23, 13:43

Commit message

Clean up a bit along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/02/23, 12:14

  2. Oliver Klee commented on patch set 1 04/02/23, 12:21

    VimeoHelperTest.php:46

    Let's use `?string` instead of `string|null`.

    VimeoHelperTest.php:50

    `if ($expectsMock) {`
  3. core-ci voted on patch set 1 V +1 04/02/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39974

  4. Christian Kuhn uploaded patch set 2 V +1 04/02/23, 12:24

  5. Christian Kuhn commented on patch set 1 04/02/23, 12:24

    VimeoHelperTest.php:46 Reply

    Done

    VimeoHelperTest.php:50 Reply

    Done
  6. core-ci voted on patch set 2 V +1 04/02/23, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39976

  7. Oliver Klee voted on patch set 2 V +1 CR +1 04/02/23, 12:51

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 04/02/23, 13:42

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 04/02/23, 13:43

  10. Christian Kuhn merged patch set 3 04/02/23, 13:43