78371[TASK] Have static DP in PlatformInformationTest
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1418
-
Christian Kuhn uploaded patch set 1 04/02/23, 12:55
-
core-ci voted on patch set 1 V +1 04/02/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39978
-
Oliver Klee commented on patch set 1 04/02/23, 13:10
PlatformInformationTest.php:42`@param class-string $platform`PlatformInformationTest.php:53Ditto. -
Oliver Klee commented on patch set 1 04/02/23, 13:15
PlatformInformationTest.php:31ReplyOr even better: `class-string<AbstractPlatform>`PlatformInformationTest.php:42Reply… and with `class-string<AbstractPlatform>`, we probably even won’t need the `@var` anymore. -
Christian Kuhn uploaded patch set 2
V +104/02/23, 13:56 -
Christian Kuhn commented on patch set 1 04/02/23, 13:56
PlatformInformationTest.php:31ReplyDonePlatformInformationTest.php:42Replystill need it since phpstorm does not understand this.PlatformInformationTest.php:53ReplyDone -
core-ci voted on patch set 2 V -1 04/02/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39984
-
Oliver Klee commented on patch set 2 04/02/23, 14:20
PlatformInformationTest.php:42ReplyI‘ll have a look on it. Hold on … -
Oliver Klee commented on patch set 2 CR -1 04/02/23, 14:20
on it -
Oliver Klee uploaded patch set 3
CR -1V -104/02/23, 14:33 -
Oliver Klee voted on patch set 3 V +1 CR +1 04/02/23, 14:33
-
Oliver Klee uploaded patch set 4
CR +1V +104/02/23, 14:34 -
Oliver Klee voted on patch set 4 V +1 CR +1 04/02/23, 14:34
-
core-ci voted on patch set 4 V +1 04/02/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39990
-
core-ci voted on patch set 3 V +1 04/02/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39989
-
Andreas Kienast voted on patch set 4 V +1 CR +1 04/03/23, 07:54
-
Christian Kuhn voted on patch set 4 V +2 CR +2 04/03/23, 07:55
-
Christian Kuhn merged patch set 5 04/03/23, 07:55
PlatformInformationTest.php:31