Review main Merged

78371[TASK] Have static DP in PlatformInformationTest

Christian Kuhn CR +2 V +2 Easy +25 −21 updated 04/03/23, 07:55

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1418

  1. Christian Kuhn uploaded patch set 1 04/02/23, 12:55

  2. core-ci voted on patch set 1 V +1 04/02/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39978

  3. Oliver Klee commented on patch set 1 04/02/23, 13:10

    PlatformInformationTest.php:31

    `@return array<string, array{0: class-string}>`

    PlatformInformationTest.php:42

    `@param class-string $platform`

    PlatformInformationTest.php:53

    Ditto.
  4. Oliver Klee commented on patch set 1 04/02/23, 13:15

    PlatformInformationTest.php:31 Reply

    Or even better: `class-string<AbstractPlatform>`

    PlatformInformationTest.php:42 Reply

    … and with `class-string<AbstractPlatform>`, we probably even won’t need the `@var` anymore.
  5. Christian Kuhn uploaded patch set 2 V +1 04/02/23, 13:56

  6. Christian Kuhn commented on patch set 1 04/02/23, 13:56

    PlatformInformationTest.php:31 Reply

    Done

    PlatformInformationTest.php:42 Reply

    still need it since phpstorm does not understand this.

    PlatformInformationTest.php:53 Reply

    Done
  7. core-ci voted on patch set 2 V -1 04/02/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39984

  8. Oliver Klee commented on patch set 2 04/02/23, 14:20

    PlatformInformationTest.php:42 Reply

    I‘ll have a look on it. Hold on …
  9. Oliver Klee commented on patch set 2 CR -1 04/02/23, 14:20

    on it
  10. Oliver Klee uploaded patch set 3 CR -1 V -1 04/02/23, 14:33

  11. Oliver Klee voted on patch set 3 V +1 CR +1 04/02/23, 14:33

  12. Oliver Klee uploaded patch set 4 CR +1 V +1 04/02/23, 14:34

  13. Oliver Klee voted on patch set 4 V +1 CR +1 04/02/23, 14:34

  14. core-ci voted on patch set 4 V +1 04/02/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39990

  15. core-ci voted on patch set 3 V +1 04/02/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39989

  16. Andreas Kienast voted on patch set 4 V +1 CR +1 04/03/23, 07:54

  17. Christian Kuhn voted on patch set 4 V +2 CR +2 04/03/23, 07:55

  18. Christian Kuhn merged patch set 5 04/03/23, 07:55