Review main Merged

78373[TASK] Turn ActionControllerTest into functionals

Christian Kuhn CR +2 V +2 Expert +315 −777 updated 04/03/23, 10:02

Commit message

Avoids phpunit 10 deprecation and failures
and allows minor modifications of ActionController.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/03/23, 07:53

  2. Christian Kuhn uploaded patch set 2 04/03/23, 07:55

  3. core-ci voted on patch set 1 V +1 04/03/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40002

  4. core-ci voted on patch set 2 V +1 04/03/23, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40003

  5. Oliver Klee commented on patch set 2 04/03/23, 08:14

    ActionController.php:564

    Can't we cover all these `method_exists` checks with a single `instanceof` check instead?

    ActionControllerTest.php:65

    We access `$subject->arguments` a lot. Let's put it in a local variable `$arguments`. Also, we have quite a lot of similar assertions in these new tests. This smells like begging for a data provider for the different types of arguments (string, integer and stdClass). :-)
  6. Christian Kuhn commented on patch set 2 04/03/23, 08:27

    ActionController.php:564 Reply

    no. we don't know the target class

    ActionControllerTest.php:65 Reply

    no. i decided to keep it simple.
  7. Benni Mack voted on patch set 2 V +1 CR +1 04/03/23, 09:16

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 04/03/23, 09:52

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 04/03/23, 10:02

  10. Christian Kuhn merged patch set 3 04/03/23, 10:02