78373[TASK] Turn ActionControllerTest into functionals
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php2+22 −61
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_test/Classes/Controller/TestController.php+44 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php2+249 −59
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.phpdeleted+0 −651
Review log 810
-
Christian Kuhn uploaded patch set 1 04/03/23, 07:53
-
Christian Kuhn uploaded patch set 2 04/03/23, 07:55
-
core-ci voted on patch set 1 V +1 04/03/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40002
-
core-ci voted on patch set 2 V +1 04/03/23, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40003
-
Oliver Klee commented on patch set 2 04/03/23, 08:14
ActionControllerTest.php:65We access `$subject->arguments` a lot. Let's put it in a local variable `$arguments`. Also, we have quite a lot of similar assertions in these new tests. This smells like begging for a data provider for the different types of arguments (string, integer and stdClass). :-) -
Christian Kuhn commented on patch set 2 04/03/23, 08:27
ActionController.php:564Replyno. we don't know the target classActionControllerTest.php:65Replyno. i decided to keep it simple. -
Benni Mack voted on patch set 2 V +1 CR +1 04/03/23, 09:16
-
Andreas Kienast voted on patch set 2 V +1 CR +1 04/03/23, 09:52
-
Christian Kuhn voted on patch set 2 V +2 CR +2 04/03/23, 10:02
-
Christian Kuhn merged patch set 3 04/03/23, 10:02
ActionController.php:564