Review main Merged

78374[TASK] Make GeneralUtilityTest phpunit 10 compatible

Christian Kuhn CR +2 V +2 Normal +44 −72 updated 04/03/23, 09:11

Commit message

Using the test class as fixture is problematic
since the constructor changes in phpunit 10.
Refactor this and clean up a bit.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1113

  1. Christian Kuhn uploaded patch set 1 04/03/23, 08:25

  2. Benni Mack commented on patch set 1 04/03/23, 08:30

    GeneralUtilityFilesystemFixture.php:31

    can we remove the vfs part? maybe even the full Fixture?
  3. core-ci voted on patch set 1 V +1 04/03/23, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40005

  4. Oliver Klee commented on patch set 1 04/03/23, 08:37

    GeneralUtilityFixture.php:29

    This is not needed anymore now that GU::flushInternalRuntimeCaches does this.
  5. Oliver Klee commented on patch set 1 04/03/23, 08:38

    GeneralUtilityTest.php:3426

    For new static function, please always let's have full native type declarations: ```php static fn (): void => 'Worked fine`, ```
  6. Christian Kuhn commented on patch set 1 04/03/23, 08:51

    GeneralUtilityFilesystemFixture.php:31 Reply

    maybe. let's look at the vfs things in dedicated patches, there are various potentially obsolete things.

    GeneralUtilityFixture.php:29 Reply

    Done

    GeneralUtilityTest.php:3426 Reply

    Done
  7. Christian Kuhn uploaded patch set 2 V +1 04/03/23, 08:52

  8. Benni Mack commented on patch set 1 V +1 CR +1 04/03/23, 08:52

    GeneralUtilityFilesystemFixture.php:31 Reply

    k
  9. Benni Mack voted on patch set 2 V +1 CR +1 04/03/23, 08:53

  10. core-ci voted on patch set 2 V +1 04/03/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40009

  11. Oliver Klee voted on patch set 2 V +1 CR +1 04/03/23, 09:02

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 04/03/23, 09:11

  13. Christian Kuhn merged patch set 3 04/03/23, 09:11