78374[TASK] Make GeneralUtilityTest phpunit 10 compatible
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/GeneralUtilityFilesystemFixture.php3+1 −4
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/GeneralUtilityTestClass.phprenamed+3 −11
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php2+37 −54
- typo3/sysext/workspaces/Tests/Unit/Domain/Model/WorkspaceRecordTest.php+3 −3
Review log 1113
-
Christian Kuhn uploaded patch set 1 04/03/23, 08:25
-
Benni Mack commented on patch set 1 04/03/23, 08:30
-
core-ci voted on patch set 1 V +1 04/03/23, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40005
-
Oliver Klee commented on patch set 1 04/03/23, 08:37
GeneralUtilityFixture.php:29This is not needed anymore now that GU::flushInternalRuntimeCaches does this. -
Oliver Klee commented on patch set 1 04/03/23, 08:38
GeneralUtilityTest.php:3426For new static function, please always let's have full native type declarations: ```php static fn (): void => 'Worked fine`, ``` -
Christian Kuhn commented on patch set 1 04/03/23, 08:51
GeneralUtilityFilesystemFixture.php:31Replymaybe. let's look at the vfs things in dedicated patches, there are various potentially obsolete things.GeneralUtilityFixture.php:29ReplyDoneGeneralUtilityTest.php:3426ReplyDone -
Christian Kuhn uploaded patch set 2
V +104/03/23, 08:52 -
Benni Mack commented on patch set 1 V +1 CR +1 04/03/23, 08:52
GeneralUtilityFilesystemFixture.php:31Replyk -
Benni Mack voted on patch set 2 V +1 CR +1 04/03/23, 08:53
-
core-ci voted on patch set 2 V +1 04/03/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40009
-
Oliver Klee voted on patch set 2 V +1 CR +1 04/03/23, 09:02
-
Christian Kuhn voted on patch set 2 V +2 CR +2 04/03/23, 09:11
-
Christian Kuhn merged patch set 3 04/03/23, 09:11
GeneralUtilityFilesystemFixture.php:31