Review main Merged

78375[TASK] Make EvaluateDisplayConditionsTest phpunit 10 compatible

Christian Kuhn CR +2 V +2 Normal +88 −116 updated 04/03/23, 09:42

Commit message

Using the test class as fixture is problematic
since the constructor changes in phpunit 10.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/03/23, 08:44

  2. core-ci voted on patch set 1 V +1 04/03/23, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40007

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/03/23, 09:06

  4. Oliver Klee voted on patch set 1 V +1 CR +1 04/03/23, 09:36

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 04/03/23, 09:36

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 04/03/23, 09:42

  7. Christian Kuhn merged patch set 2 04/03/23, 09:42