Review main Merged

78377[TASK] Have SilentConfigurationUpgradeServiceTest functionals

Christian Kuhn CR +2 V +2 Expert +753 −990 updated 04/03/23, 13:26

Commit message

Turns existing unit tests into functionals, making
them more concise, avoids mocking parties, and
makes them better maintainable.

SilentConfigurationUpgradeService is slightly
cleaned up along the way, together with a minor
fix regarding a missing BE/lang/debug removal,
which was now found by the functional tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/03/23, 12:50

  2. Oliver Klee updated the commit message in patch set 2 04/03/23, 12:53

  3. Christian Kuhn updated the commit message in patch set 3 04/03/23, 12:54

  4. core-ci voted on patch set 3 V +1 04/03/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40015

  5. Christian Kuhn updated the commit message in patch set 4 V +1 04/03/23, 13:07

  6. core-ci voted on patch set 4 V +1 04/03/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40016

  7. Benni Mack voted on patch set 4 V +1 CR +1 04/03/23, 13:18

  8. Andreas Kienast voted on patch set 4 V +1 CR +1 04/03/23, 13:18

  9. Christian Kuhn voted on patch set 4 V +2 CR +2 04/03/23, 13:26

  10. Christian Kuhn merged patch set 5 04/03/23, 13:26