78377[TASK] Have SilentConfigurationUpgradeServiceTest functionals
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Configuration/ConfigurationManager.php+1 −1
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+102 −100
- typo3/sysext/install/Tests/Functional/Service/SilentConfigurationUpgradeServiceTest.phpnew+650 −0
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.phpdeleted+0 −884
Review log 810
-
Christian Kuhn uploaded patch set 1 04/03/23, 12:50
-
Oliver Klee updated the commit message in patch set 2 04/03/23, 12:53
-
Christian Kuhn updated the commit message in patch set 3 04/03/23, 12:54
-
core-ci voted on patch set 3 V +1 04/03/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40015
-
Christian Kuhn updated the commit message in patch set 4
V +104/03/23, 13:07 -
core-ci voted on patch set 4 V +1 04/03/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40016
-
Benni Mack voted on patch set 4 V +1 CR +1 04/03/23, 13:18
-
Andreas Kienast voted on patch set 4 V +1 CR +1 04/03/23, 13:18
-
Christian Kuhn voted on patch set 4 V +2 CR +2 04/03/23, 13:26
-
Christian Kuhn merged patch set 5 04/03/23, 13:26