Review main Merged

78378[TASK] Remove AbstractPluginTest

Christian Kuhn CR +2 V +2 Hard +0 −340 updated 04/03/23, 14:45

Commit message

AbstractPlugin ("Pi1" FE plugins) has been
marked as "not maintained anymore" a while
ago.

The unit tests are a heavily mocking aweful
mess, most of them look at details that are
obvious reading the implementation. The
central topics like the ContentObjectRenderer
have unit tests on their own to sort out details.

AbstractPlugin may see a final deprecation
and there are little code changes in general.

The patch removes the "unit" tests to reduce
maintenance nightmares in this area, the tests
don't add much value.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 04/03/23, 13:26

  2. Christian Kuhn updated the commit message in patch set 2 04/03/23, 13:30

  3. Andreas Kienast voted on patch set 2 V +1 CR +1 04/03/23, 13:38

  4. core-ci voted on patch set 2 V +1 04/03/23, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40018

  5. core-ci voted on patch set 1 V +1 04/03/23, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40017

  6. Oliver Klee voted on patch set 2 V +1 CR +1 04/03/23, 14:33

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 04/03/23, 14:44

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 04/03/23, 14:45

  9. Oli Bartsch merged patch set 3 04/03/23, 14:45