Review main Merged

78379[TASK] Avoid withConsecutive() in RequestHandlerTest

Christian Kuhn CR +2 V +2 Easy +17 −3 updated 04/03/23, 14:46

Commit message

Even though the RequestHandlerTest unit tests
are an aweful mocking party, we can't simply
throw them away since the class is so important.

They should still be turned into functional
tests later, to be more useful, maybe together
with a refactoring of that class.

The patch just changes the tests to avoid
withConsecutive(), which does not improve
the situation, but a bigger refactoring
is currently a bit too much with our current
goal of "just" adding phpunit 10 compatibility.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/03/23, 14:09

  2. core-ci voted on patch set 1 V +1 04/03/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40020

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 04/03/23, 14:21

  4. Oliver Klee voted on patch set 1 V +1 CR +1 04/03/23, 14:32

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 04/03/23, 14:44

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 04/03/23, 14:46

  7. Oli Bartsch merged patch set 2 04/03/23, 14:46