Review main Merged

78385[TASK] Avoid withConsecutive() in ContentObjectRendererTest

Christian Kuhn CR +2 V +2 Normal +107 −139 updated 04/04/23, 07:23

Commit message

Rewriting the tests to mock less makes them
better readable and far easier to grasp.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Christian Kuhn uploaded patch set 1 04/03/23, 21:27

  2. core-ci voted on patch set 1 V -1 04/03/23, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40036

  3. Christian Kuhn uploaded patch set 2 V -1 04/03/23, 22:02

  4. core-ci voted on patch set 2 V +1 04/03/23, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40039

  5. Oliver Klee voted on patch set 2 V +1 CR +1 04/04/23, 05:54

  6. Benni Mack voted on patch set 2 V +2 CR +2 04/04/23, 07:23

  7. Benni Mack merged patch set 3 04/04/23, 07:23