Review main Merged

78386[TASK] Avoid withConsecutive() in SaveToDatabaseFinisherTest

Christian Kuhn CR +2 V +2 Easy +3 −7 updated 04/04/23, 07:19

Commit message

Testing for the input keys is rather useless, it's
enough to verify the sub method is called twice.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 04/03/23, 21:37

  2. core-ci voted on patch set 1 V +1 04/03/23, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40037

  3. Oliver Klee voted on patch set 1 V +1 CR +1 04/04/23, 05:55

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/04/23, 07:19

  5. Benni Mack merged patch set 2 04/04/23, 07:19