Review main Merged

78387[TASK] Avoid invalid methods in FormDefinitionValidationServiceTest

Christian Kuhn CR +2 V +2 Normal +83 −101 updated 04/04/23, 07:18

Commit message

The tests try to configure method mocks that don't
exist. The patch adapts the tests accordingly. They
should receive a bigger overhaul, though.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 04/03/23, 22:00

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 04/03/23, 22:01

  3. Christian Kuhn voted on patch set 1 V 0 CR 0 04/03/23, 22:01

  4. core-ci voted on patch set 1 V +1 04/03/23, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40038

  5. Oliver Klee voted on patch set 1 V +1 04/04/23, 05:55

  6. Oliver Klee voted on patch set 1 CR +1 04/04/23, 05:57

  7. Benni Mack voted on patch set 1 V +2 CR +2 04/04/23, 07:18

  8. Benni Mack merged patch set 2 04/04/23, 07:18