Review main Merged

78388[TASK] Streamline InstallUtilityTest

Christian Kuhn CR +2 V +2 Normal +10 −212 updated 04/04/23, 07:24

Commit message

Avoid mocking not existing methods in one
test. Remove two other tests that mock so
much that it's very hard to understand
what they try to achieve in the first place.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 04/03/23, 22:24

  2. core-ci voted on patch set 1 V +1 04/03/23, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40040

  3. Oliver Klee voted on patch set 1 V +1 CR +1 04/04/23, 05:54

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/04/23, 07:24

  5. Benni Mack merged patch set 2 04/04/23, 07:24