Review main Merged

78435[TASK] Avoid withConsecutive() in ServiceProviderRegistryTest

Christian Kuhn CR +2 V +2 Normal +24 −41 updated 04/04/23, 09:29

Commit message

The two mocked methods are not called by the
test subject - probably due to an earlier
refactoring regarding package load state.
The two withConsecutive() calls can be removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/04/23, 08:21

  2. core-ci voted on patch set 1 V +1 04/04/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40059

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 04/04/23, 09:02

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 04/04/23, 09:16

  5. Oliver Klee voted on patch set 1 V +1 CR +1 04/04/23, 09:21

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 04/04/23, 09:29

  7. Christian Kuhn merged patch set 2 04/04/23, 09:29