Review main Merged

78439[BUGFIX] Fix invalid array access in Mail\TransportFactory

Oliver Klee CR +2 V +2 Easy +7 −6 updated 04/04/23, 16:00

Commit message

Even for a broken/imcomplete configuration, we want to have the
exception that complains about the incomplete configuration instead
of a `TypeError`.

Also add some type casts to have predictable types in more cases.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Oliver Klee uploaded patch set 1 04/04/23, 09:49

  2. Oliver Klee uploaded patch set 2 04/04/23, 10:05

  3. core-ci voted on patch set 1 V +1 04/04/23, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40070

  4. core-ci voted on patch set 2 V +1 04/04/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40074

  5. Oliver Klee uploaded patch set 3 V +1 04/04/23, 10:43

  6. Christian Kuhn commented on patch set 2 V +1 CR +1 04/04/23, 10:45

    note: found by phpunit 10 upgrade ;)
  7. Christian Kuhn voted on patch set 3 V +1 CR +1 04/04/23, 10:47

  8. core-ci voted on patch set 3 V +1 04/04/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40075

  9. Benni Mack voted on patch set 3 V +1 CR +1 04/04/23, 14:56

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 04/04/23, 16:00

  11. Christian Kuhn merged patch set 4 04/04/23, 16:00