78443[TASK] Add tests for backend view module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Tymoteusz Motylewski +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Tymoteusz Motylewski +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1621
-
Wiktor Woźny uploaded patch set 1 04/04/23, 11:23
-
Wiktor Woźny uploaded patch set 2 04/04/23, 11:25
-
Wiktor Woźny uploaded patch set 3 04/04/23, 11:53
-
core-ci voted on patch set 2 V -1 04/04/23, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40080
-
core-ci voted on patch set 1 V -1 04/04/23, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40079
-
core-ci voted on patch set 3 V -1 04/04/23, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40083
-
Tymoteusz Motylewski commented on patch set 3 04/04/23, 13:46
the acc tests are failing with Found following JavaScript errors in the browser console: 11:35:27.429 SEVERE - http://web:8000/typo3temp/var/tests/acceptance/typo3/module/web/viewpage?token=3db2c7310033bafdc82036f2ef9554d5e7397cba&id=51& 474 Refused to frame 'http://localhost/'; because it violates the following Content Security Policy directive: "frame-src 'self' *.youtube-nocookie.com *.youtube.com *.vimeo.com blob:". As backend site is configured with base: 'http://localhost/styleguide-demo-6'; while acc tests are using http://web:8000/typo3temp/var/tests/acceptance/. -
Oliver Hader commented on patch set 3 04/05/23, 09:45
→ requires the bugfix of https://review.typo3.org/c/Packages/TYPO3.CMS/+/78473 first -
Oliver Hader rebased onto patch set 4
V -104/05/23, 09:59 -
core-ci voted on patch set 4 V -1 04/05/23, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40171
-
Oliver Hader commented on patch set 4 04/05/23, 10:15
> 10:12:00.831 SEVERE - http://web:8000/typo3temp/var/tests/acceptance/typo3/module/web/viewpage?token=ca455c22f88def2897360d00cc754844b742ee39&id=227& - The source list for the Content Security Policy directive 'frame-src' contains an invalid source: '/typo3temp/var/tests/acceptance/styleguide-demo-227/'. It will be ignored. Seems like the site config needs to be consolidated as well `/typo3temp/var/tests/acceptance/styleguide-demo-227/`. -
Oliver Hader commented on patch set 4 04/05/23, 10:15
Reply
No idea why it was `http://localhost` previously -
Oliver Hader commented on patch set 4 04/05/23, 14:18
I was not able to reproduce this locally when running acceptance tests. There are a bunch of fallbacks, that are using `localhost` as `HTTP_HOST` in case it's empty of invoked from CLI. I have no idea how to debug this, since I cannot reproduce the behavior of the GitHub CI on my local environment. -
Benni Mack updated the commit message in patch set 5
V -105/03/23, 09:43 -
Benni Mack rebased onto patch set 6 06/15/23, 21:53
-
core-ci voted on patch set 6 V +1 06/15/23, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42698
-
Oliver Klee voted on patch set 6 V +1 06/16/23, 07:29
-
Tymoteusz Motylewski commented on patch set 6 V +1 CR +1 06/16/23, 09:53
Reply
seems the CI is happy now, after the rebase -
Andreas Kienast voted on patch set 6 CR +1 06/16/23, 10:08
-
Benni Mack voted on patch set 6 V +2 CR +2 06/19/23, 07:27
-
Benni Mack merged patch set 7 06/19/23, 07:27