Review main Merged

78453[TASK] Avoid withConsecutive() in ExpressionBuilderTest

Christian Kuhn CR +2 V +2 Normal +74 −33 updated 04/04/23, 17:24

Commit message

Pretty straight substitution as done with
similar phpunit 10 compatibility patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1

Issues 2

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/04/23, 16:17

  2. core-ci voted on patch set 1 V +1 04/04/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40101

  3. Oliver Klee commented on patch set 1 04/04/23, 16:26

    ExpressionBuilderTest.php:31

    I think `$subject` does not need to be nullable.
  4. Christian Kuhn uploaded patch set 2 V +1 04/04/23, 16:35

  5. Christian Kuhn commented on patch set 1 04/04/23, 16:35

    ExpressionBuilderTest.php:31 Reply

    Done
  6. Oliver Klee voted on patch set 2 CR +1 04/04/23, 17:08

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 04/04/23, 17:21

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 04/04/23, 17:22

  9. Christian Kuhn merged patch set 3 04/04/23, 17:22

  10. core-ci voted on patch set 2 V +1 04/04/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40105