Review main Merged

78459[BUGFIX] Add external media CSP declarations to frontend scope

Oliver Hader CR +2 V +2 Normal +44 −42 updated 04/06/23, 07:53

Commit message

Previously external media CSP declarations (e.g. to embed YouTube
or Vimeo assets in an iframe) was only applied to the backend scope,
when `ext:filelist` was installed. However, the same declarations
are required in the frontend scope for actually rendering those
external media content elements.

The initiating components `YouTubeRenderer` and `VimeoRenderer` are
located in `ext:core`. That's why the CSP declarations are moved
there as well.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oliver Hader uploaded patch set 1 04/04/23, 19:14

  2. core-ci voted on patch set 1 V +1 04/04/23, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40118

  3. Markus Klein voted on patch set 1 CR +1 04/04/23, 22:16

  4. Benni Mack commented on patch set 1 V +1 CR +1 04/05/23, 21:02

    even though EXT:filelist is required (AFAIK) this change still makes sense to apply
  5. Oli Bartsch voted on patch set 1 V +1 CR +1 04/06/23, 07:26

  6. Oliver Hader commented on patch set 1 V +2 CR +2 04/06/23, 07:53

    Thx folks!
  7. Oliver Hader merged patch set 2 04/06/23, 07:53