Review main Merged

78460[TASK] Declare all test classes final

Wouter Wolters CR +2 V +2 Expert +1303 −1083 updated 04/11/23, 09:42

Commit message

Test classes should never extend each other.
phpunit 10 is also a bit more picky about naming
of abstract test cases.

The patch adds a script to verify all test case
files are declared final, adds it to CI, and
adapts existing tests accordingly.

> Build/Scripts/runTests.sh -s checkTestClassFinal

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1089

Show 1069 more files

Review log 1118

  1. Wouter Wolters uploaded patch set 1 04/04/23, 20:48

  2. Wouter Wolters uploaded patch set 2 04/04/23, 20:48

  3. Wouter Wolters uploaded patch set 3 04/04/23, 20:52

  4. core-ci voted on patch set 1 V -1 04/04/23, 21:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40120

  5. core-ci voted on patch set 2 V -1 04/04/23, 21:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40121

  6. core-ci voted on patch set 3 V -1 04/04/23, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40122

  7. Christian Kuhn uploaded patch set 4 V -1 04/06/23, 19:31

  8. core-ci voted on patch set 4 V -1 04/06/23, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40317

  9. Christian Kuhn commented on patch set 4 04/06/23, 20:31

    pre-patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78531 other than that, i think we're pretty much fine to finish the patch. i'll be offline for a couple of days, but would pick up after easter again.
  10. Christian Kuhn uploaded patch set 5 V -1 04/10/23, 14:17

  11. core-ci voted on patch set 5 V -1 04/10/23, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40410

  12. Christian Kuhn uploaded patch set 6 V -1 04/10/23, 16:04

  13. core-ci voted on patch set 6 V -1 04/10/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40413

  14. Christian Kuhn uploaded patch set 7 V -1 04/10/23, 16:21

  15. core-ci voted on patch set 7 V +1 04/10/23, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40415

  16. Christian Kuhn voted on patch set 7 V +1 CR +1 04/10/23, 16:41

  17. Benni Mack voted on patch set 7 V +2 CR +2 04/11/23, 09:42

  18. Benni Mack merged patch set 8 04/11/23, 09:42