Review main Merged

78462[TASK] Have static DP in ReactionsRepositoryTest

Christian Kuhn CR +2 V +2 Normal +28 −27 updated 04/05/23, 02:18

Commit message

Avoid a useless helper method by having
object creation within data provider
directly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 04/04/23, 21:37

  2. Christian Kuhn uploaded patch set 2 04/04/23, 21:37

  3. core-ci voted on patch set 2 V +1 04/04/23, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40129

  4. core-ci voted on patch set 1 V -1 04/04/23, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40128

  5. Oliver Klee voted on patch set 2 V +1 04/04/23, 22:22

  6. Oliver Klee voted on patch set 2 CR +1 04/04/23, 22:24

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 04/05/23, 02:18

  8. Stefan Bürk merged patch set 3 04/05/23, 02:18