Review main Merged

78464[TASK] Have static DP in BrokenLinkRepositoryTest

Christian Kuhn CR +2 V +2 Normal +47 −152 updated 04/05/23, 08:24

Commit message

Clean up and simplify a bit along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/04/23, 21:56

  2. core-ci voted on patch set 1 V +1 04/04/23, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40132

  3. Oliver Klee voted on patch set 1 V +1 04/04/23, 22:22

  4. Oliver Klee commented on patch set 1 04/04/23, 22:25

    BrokenLinkRepositoryTest.php:33

    If we‘re touching this anyway, we can also directly make it a const.
  5. Christian Kuhn uploaded patch set 2 V +1 04/04/23, 22:37

  6. Christian Kuhn commented on patch set 2 04/04/23, 22:37

    BrokenLinkRepositoryTest.php:33 Reply

    Done
  7. core-ci voted on patch set 2 V +1 04/04/23, 22:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40134

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 04/05/23, 02:22

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 04/05/23, 08:24

  10. Christian Kuhn merged patch set 3 04/05/23, 08:24