Review main Merged

78465[TASK] Have more static DP in SiteHandling tests

Christian Kuhn CR +2 V +2 Hard +93 −171 updated 04/05/23, 08:36

Commit message

Solves simple cases: Make some helper methods
static, call them statically, and declace
consuming data providers static.

There are more hairy cases in this section,
those will be sorted out with further patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 56

  1. Christian Kuhn uploaded patch set 1 04/04/23, 22:33

  2. core-ci voted on patch set 1 V +1 04/04/23, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40133

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 04/05/23, 02:26

  4. Benni Mack voted on patch set 1 V +1 CR +1 04/05/23, 08:35

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/05/23, 08:36

  6. Christian Kuhn merged patch set 2 04/05/23, 08:36